feat(add): #8 option to only/exclude files by ext#9
Merged
danielebriggi merged 4 commits intomainfrom Oct 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for selectively including or excluding files by extension when adding documents, and updates tests accordingly.
- Introduces only_extensions and exclude_extensions parameters to CLI, SQLiteRag.add, and FileReader APIs.
- Refactors FileReader.extensions to drop leading dots and enhances filtering logic.
- Expands test coverage for new filtering behavior.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_sqlite_rag.py | Adds tests for add() with only/exclude extension combinations and single-file scenarios. |
| tests/test_reader.py | Updates existing tests for new extension style and adds comprehensive coverage for only/exclude logic. |
| src/sqlite_rag/sqliterag.py | Passes new filtering parameters through to FileReader.collect_files. |
| src/sqlite_rag/reader.py | Refactors extension list format and implements only/exclude filtering in is_supported and collect_files. |
| src/sqlite_rag/cli.py | Adds CLI options --only / --exclude and parses them into lists. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket #8